This comment shows the latest Codex review activity on this pull request.

Full summary

Pull request purpose (title): feat(render): compact search results and bounded page contents. This PR adds opt-in compactness controls without changing default output: `RenderOptions` with `render_text_with`/`render_markdown_with` (configurable excerpt caps, per-page contents caps, and source compaction via `RenderOptions::compact()`), plus `ProviderConfig.contents_max_chars`, which reaches Exa contents calls as `text.maxCharacters` on both direct and backend routes and is clamped to a 1,500-character per-page bound. Normalization now keeps up to 1,500 characters per page for contents-role tools while search snippets stay at 1,200. The latest-push delta is unavailable, so this describes the whole pull-request change.

Review snapshot

Completeness: Complete
Test assessment: Test coverage is assessed from changed tests and lane evidence; execution is not claimed without trusted check data.

What changed

The render module gains an `options` submodule exporting `TEXT_EXCERPT_CHARS` and `COMPACT_CONTENTS_CHARS`, and the existing `render_text`/`render_markdown` become thin wrappers over new `_with` variants that take `RenderOptions`. A new `sources` helper filters citations when `compact_sources` is on: citations whose URL matches one of the first `max_results` results are dropped, and the remainder are capped at `max_results`, with numbering preserved from the original citation list. Provider config adds `contents_max_chars` (serde round-trip, Default, and Debug redaction-consistent field), which `direct::apply_contents_cap` injects into `exa_get_contents` as `max_characters` only when the caller set none, clamped to at least 1 and at most `MAX_PAGE_CHARS`. `exa_body` converts a positive `max_characters` into `text.maxCharacters`, otherwise sends `text: true`. Normalization picks a per-role snippet cap using `role_provider_tool(Role::Contents, ...)`. README documents the render options and the provider setting.

Features

• Added — Source compaction in rendered output: With `compact_sources`, citations duplicating listed results are omitted and remaining sources are bounded by `max_results`, reducing redundancy in text and markdown output. (crates/tinysearch-bus/src/render/mod.rs, crates/tinysearch-bus/src/render/mod_tests.rs)
• Internal refactor — Debug output and serde defaults for the new config field: `ProviderConfig` Debug includes `contents_max_chars`, and legacy payloads without the field deserialize to `None`, preserving existing behavior. (crates/tinysearch-bus/src/search/types.rs impl fmt::Debug for ProviderConfig {, crates/tinysearch-bus/src/search/types.rs impl Default for ProviderConfig {)

Tests

• unit — Compaction in text and markdown: default keeps `Sources`, compact drops duplicated sources but retains non-result citations, treats results hidden by `max_results` as unlisted, and caps sources at `max_results`.: The tests assert specific rendered strings and occurrence counts of result URLs, so a regression in the `sources` filtering would surface. Test lane reported an answered status with no findings. (crates/tinysearch-bus/src/render/mod_tests.rs)
• unit — Excerpt and contents caps apply to the correct role, the default contents cap reproduces the prior 500-character output, and `RenderOptions` deserializes with defaults and round-trips.: Assertions check exact character counts and truncation boundaries for both renderers. Test lane reported an answered status with no findings. (crates/tinysearch-bus/src/render/mod_tests.rs, crates/tinysearch-bus/src/render/options.rs)
• unit — Exa request bodies ask for whole pages when uncapped, send `maxCharacters` for a positive cap, and ignore zero, malformed, or negative values.: Direct assertions on the produced body and path. Test lane reported an answered status with no findings. (crates/tinysearch/src/provider/direct/exa_tests.rs fn only_search_takes_a_type() -> Result<()> {, crates/tinysearch/src/provider/direct/exa.rs)
• integration — A configured `contents_max_chars` reaches the mock server's request as `maxCharacters` and the normalized snippet is bounded to 1,500 characters; over-large caps clamp to 1,500; search calls and caller-specified caps are untouched; search snippets stay at 1,200.: Covers both the request side and the normalized result, exercising direct and backend request building. Test lane reported an answered status with no findings. (crates/tinysearch/src/provider/mod_tests.rs async fn exa_direct_operations_map_and_normalize() -> TestResult<()> {, crates/tinysearch/src/provider/normalize.rs, crates/tinysearch/src/provider/direct/mod.rs)

Findings

No active actionable findings.

Before merge

None.

The change adds configurable text and Markdown rendering options, including compact source lists. It also adds an optional per-page character cap for Exa contents requests and applies different snippet limits to contents and search results.

Changes: Content limits and rendering

Layer / File(s)	Summary
Render options and output crates/tinysearch-bus/src/render/options.rs, crates/tinysearch-bus/src/render/mod.rs, crates/tinysearch-bus/src/render/mod_tests.rs, README.md	RenderOptions configures excerpt and contents lengths and compact source selection. Text and Markdown rendering use the options, and tests cover the defaults and compact behavior.
Exa contents caps and normalization crates/tinysearch-bus/src/search/types.rs, crates/tinysearch-bus/src/search/mod_tests.rs, crates/tinysearch/src/provider/mod.rs, crates/tinysearch/src/provider/direct/*, crates/tinysearch/src/provider/normalize.rs, crates/tinysearch/src/provider/mod_tests.rs, README.md	Provider configuration adds contents_max_chars. Exa contents requests use the configured cap when no request-level cap is set. Normalization clips contents snippets at 1,500 characters and other snippets at 1,200 characters.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant ProviderConfig
  participant ProviderRoute
  participant ExaContents
  participant Normalizer
  ProviderConfig->>ProviderRoute: contents_max_chars
  ProviderRoute->>ExaContents: maxCharacters
  ExaContents->>Normalizer: contents response
  Normalizer->>Normalizer: clip contents snippets to MAX_PAGE_CHARS

Loading

Possibly related PRs

• tinyhumansai/tinysearch#41: Adds the Contents-role tool mapping that this change uses to select the contents snippet limit.

Suggested reviewers: tinysweeper

Merge Risk: Low · up to b99eb

The change is mergeable with awareness of two bounded issues: compact output can repeat equivalent URLs, and some non-Exa contents render differently without opting in.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 43.75% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "feat(render): compact search results and bounded page contents" matches the main changes. The PR adds RenderOptions with compact_sources to omit duplicate source entries (compact search res…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "feat(render): compact search results and bounded page contents" matches the main changes. The PR adds RenderOptions with compact_sources to omit duplicate source entries (compact search results). It also adds contents_max_chars and a per-page cap for Exa contents (bounded page contents). The title is specific, follows a conventional-commit style, and names both primary parts of the change. It does not describe anything absent from the changeset.

Full details: Docstring Coverage

Explanation

Docstring coverage is 43.75% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 16 functions across 11 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.